Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(promtail): Update Promtail base image to Debian 12.5 #12672

Merged
merged 1 commit into from
Apr 18, 2024
Merged

chore(promtail): Update Promtail base image to Debian 12.5 #12672

merged 1 commit into from
Apr 18, 2024

Conversation

chaudum
Copy link
Contributor

@chaudum chaudum commented Apr 18, 2024 •
edited
Loading

What this PR does / why we need it:

Debian 11 (Bullseye) has been superseded by Debian 12 (Bookworm).

Which issue(s) this PR fixes:

Ref #838 (comment)

Special notes for your reviewer:

$ trivy image -q grafana/promtail:chaudum-promtail-base-image-6336f56

grafana/promtail:chaudum-promtail-base-image-6336f56 (debian 12.5)

Total: 100 (UNKNOWN: 0, LOW: 67, MEDIUM: 23, HIGH: 9, CRITICAL: 1)

The 1 CRITICAL is a "will_not_fix":

screenshot_20240418_155745

Checklist

  • Reviewed the CONTRIBUTING.md guide (required)
  • Documentation added
  • Tests updated
  • Title matches the required conventional commits format, see here
  • Changes that require user attention or interaction to upgrade are documented in docs/sources/setup/upgrade/_index.md
  • For Helm chart changes bump the Helm chart version in production/helm/loki/Chart.yaml and update production/helm/loki/CHANGELOG.md and production/helm/loki/README.md. Example PR
  • If the change is deprecating or removing a configuration option, update the deprecated-config.yaml and deleted-config.yaml files respectively in the tools/deprecated-config-checker directory. Example PR

@chaudum
chore(promtail): Update Promtail base image to Debian 12.5
f064bd7 
Signed-off-by: Christian Haudum <christian.haudum@gmail.com>
@chaudum chaudum force-pushed the chaudum/promtail-base-image branch from 6336f56 to f064bd7 Compare April 18, 2024 15:52
@chaudum chaudum marked this pull request as ready for review April 18, 2024 15:52
@chaudum chaudum requested a review from a team as a code owner April 18, 2024 15:52
MichelHollands
MichelHollands approved these changes Apr 18, 2024
View reviewed changes
Copy link
Contributor

@MichelHollands MichelHollands left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@chaudum chaudum merged commit 019f364 into main Apr 18, 2024
12 checks passed
@chaudum chaudum deleted the chaudum/promtail-base-image branch April 18, 2024 16:09
@RodrigoCMoraes RodrigoCMoraes mentioned this pull request Jul 12, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MichelHollands MichelHollands MichelHollands approved these changes

Assignees
No one assigned
Labels
size/M
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@chaudum @MichelHollands